Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resource "azurerm_data_protection_backup_instance_blob_storage" #13071

Closed
wants to merge 2 commits into from
Closed

new resource "azurerm_data_protection_backup_instance_blob_storage" #13071

wants to merge 2 commits into from

Conversation

owenfarrell
Copy link
Contributor

@owenfarrell owenfarrell commented Aug 20, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request adds support for enabling operational backups on storage accounts. The implementation and the acceptance tests are largely derived from analagous implementations for PostgreSQL database backups.

Closes: #13007

Output from acceptance testing:

$ make acctests SERVICE='dataprotection' TESTARGS='-run=TestAccDataProtectionBackupInstanceBlobStorage_' TESTTIMEOUT='15m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/dataprotection -run=TestAccDataProtectionBackupInstanceBlobStorage_ -timeout 15m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataProtectionBackupInstanceBlobStorage_basic
=== PAUSE TestAccDataProtectionBackupInstanceBlobStorage_basic
=== RUN   TestAccDataProtectionBackupInstanceBlobStorage_requiresImport
=== PAUSE TestAccDataProtectionBackupInstanceBlobStorage_requiresImport
=== RUN   TestAccDataProtectionBackupInstanceBlobStorage_complete
=== PAUSE TestAccDataProtectionBackupInstanceBlobStorage_complete
=== RUN   TestAccDataProtectionBackupInstanceBlobStorage_update
=== PAUSE TestAccDataProtectionBackupInstanceBlobStorage_update
=== CONT  TestAccDataProtectionBackupInstanceBlobStorage_basic
=== CONT  TestAccDataProtectionBackupInstanceBlobStorage_update
=== CONT  TestAccDataProtectionBackupInstanceBlobStorage_complete
=== CONT  TestAccDataProtectionBackupInstanceBlobStorage_requiresImport
--- PASS: TestAccDataProtectionBackupInstanceBlobStorage_basic (275.75s)
--- PASS: TestAccDataProtectionBackupInstanceBlobStorage_complete (308.91s)
--- PASS: TestAccDataProtectionBackupInstanceBlobStorage_requiresImport (347.88s)
--- PASS: TestAccDataProtectionBackupInstanceBlobStorage_update (624.21s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/dataprotection        628.362s

@owenfarrell owenfarrell changed the title new resource "azurerm_data_protection_backup_instance_blob_storage" new resource "azurerm_data_protection_backup_instance_blob_storage" Aug 20, 2021
@owenfarrell owenfarrell mentioned this pull request Aug 27, 2021
Merged
@katbyte
Copy link
Collaborator

katbyte commented Sep 3, 2021

Thanks @owenfarrell - going to close this in favour of #12683 as it was opened first and discussion was mostly carried out there

@katbyte katbyte closed this Sep 3, 2021
@katbyte katbyte added this to the V2.77.0 milestone Sep 3, 2021
@katbyte katbyte modified the milestones: V2.77.0, v2.76.0 Sep 3, 2021
@github-actions
Copy link

This functionality has been released in v2.76.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation new-resource service/data-protection size/XL
Projects
None yet
Milestone
v2.76.0
Development

Successfully merging this pull request may close these issues.

Incorrect documentation for data_protection_backup_instance_disk
2 participants
@owenfarrell @katbyte